Add wildfly-maven-plugin to CI
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may have inadvertently discovered a legitimate JBoss Modules bug 🥲 |
jamezp
reviewed
Sep 25, 2023
| cd wildfly-maven-plugin | ||
| mvn -B -ntp versions:update-parent -DallowSnapshots=true -N | ||
| git diff pom.xml | ||
| mvn -B -ntp install -Djava8.home=${{env.JAVA_HOME_8_X64}} -Djava11.home=${{env.JAVA_HOME_11_X64}} |
There was a problem hiding this comment.
Will this work? The wildfly-maven-plugin requires Java 11 and uses the org.wildfly.tools:wildfly-parent https://github.com/wildfly/wildfly-maven-plugin/blob/61bfbe9dd704afe92ad07e686e3425f45ec88085/pom.xml#L27-L31.
There was a problem hiding this comment.
Yes, specifying a java8.home doesn't cause the profile to run; it only runs if the control file is present. The idea is that if we cut & paste the entry for other projects, we don't lose anything.
That said, we've since dropped Java 8 support from the POM in #207 so we could drop the install action for Java 8 and these properties without any side-effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.